Miscellaneous WIP and/or hacky tree styling changes#980
Closed
Miscellaneous WIP and/or hacky tree styling changes#980
Conversation
georgefst
force-pushed
the
georgefst/zurihac
branch
from
58efe73 to
7c97307
Compare
Signed-off-by: George Thomas <georgefsthomas@gmail.com>
Signed-off-by: George Thomas <georgefsthomas@gmail.com>
well, almost all - we still use black for Ann due to running out of good colours in our palette we try to colour type nodes analogously to corresponding term nodes - this makes more sense now that we use different shapes for terms and types this probably requires a little more thought e.g. we style term Lam and type LAM differently, choosing instead to highlight their analogies with TFun and TForall directly also, I personally think "blue-secondary" looks quite odd on the canvas, but it's fine for now since it's used for advanced features (polymorphism) we should also consider refactors to make this sort of change less laborious, though it's hard to say how to abstract colours properly when tailwind discourages concatenating class strings Signed-off-by: George Thomas <georgefsthomas@gmail.com>
we should do something better for non-empty holes really, but this still seems an improvement - the braces were a weird holdover from vonnegut text mode this is a little broken in beginner mode Signed-off-by: George Thomas <georgefsthomas@gmail.com>
this causes some redundancy in beginner mode a better solution is to separate the text used in expert mode from the label text used in expert mode - even though they will usually be the same, there are cases like this where they shouldn't be - this may also solve the hole rendering issue from the previous commit Signed-off-by: George Thomas <georgefsthomas@gmail.com>
we were already using `@` for two different concepts, so we may as well unify all three - we can now easily tell which sort of application is in use by the shape of children `$` is a weird Haskell-ism that isn't really used elsewhere Signed-off-by: George Thomas <georgefsthomas@gmail.com>
This reverts commit b3cfbe9. the wording was actually truncated - let's revisit this when we have dynamically-sizable nodes Signed-off-by: George Thomas <georgefsthomas@gmail.com>
Signed-off-by: George Thomas <georgefsthomas@gmail.com>
these seem redundant, since patterns already look so different to everthing else we may wish to re-introduce these in beginner mode Signed-off-by: George Thomas <georgefsthomas@gmail.com>
dhess
reviewed
Jun 11, 2023
| case "TLet": | ||
| return "let"; | ||
| case "Pattern": | ||
| return "P"; |
Member
There was a problem hiding this comment.
I was just playing with replacing this with "Pattern" — might as well be explicit about it at beginner level, and we have the space. I agree it could be dropped altogether at higher levels.
Member
|
I like most of these changes, FYI. |
Member
|
I have rebased most of these on current I did skip the hole styling in this PR because I'm pretty happy with current |
This was referenced Jun 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apologies for the mess - review the behaviour and not the code!
Tidies up some of our more egregious visual issues with trees. Cherry-picks stuff from #932 and an older version of #863 which I used for a demo to the team around two months ago.
I intend to run the Zurihac demo from this branch, unless any of these changes are really controversial.