Skip to content

Comments

refactor: rename MakeConSat -> MakeCon#994

Merged
brprice merged 1 commit intomainfrom
brprice/rename-makecon
May 16, 2023
Merged

refactor: rename MakeConSat -> MakeCon#994
brprice merged 1 commit intomainfrom
brprice/rename-makecon

Conversation

@brprice
Copy link
Contributor

@brprice brprice commented May 16, 2023

No description provided.

@brprice
Copy link
Contributor Author

brprice commented May 16, 2023

There are some odd failures in CI (https://buildkite.com/hackworthltd/primer/builds/3317). @dhess: any ideas? (I forgot to add a Signed-off-by, but I guess this is orthogonal?)

@georgefst
Copy link
Contributor

There are some odd failures in CI (https://buildkite.com/hackworthltd/primer/builds/3317). @dhess: any ideas? (I forgot to add a Signed-off-by, but I guess this is orthogonal?)

Same on #949.

@dhess
Copy link
Member

dhess commented May 16, 2023

I was able to restart these, and they seem to have worked this time.

That said, I suspect we're seeing a new aarch64-darwin Nix bug introduced in the last week or two. It appears to be GC'ing too rapidly, causing packages that were present for one build disappearing in the next, and that the build assumed were already present in the local Nix store. I've seen this on a few of our other projects, as well.

@dhess
Copy link
Member

dhess commented May 16, 2023

Signed-off-by: Ben Price <ben@hackworthltd.com>
@brprice brprice force-pushed the brprice/rename-makecon branch from c9fdc8a to d8a8e2a Compare May 16, 2023 15:00
@brprice brprice added this pull request to the merge queue May 16, 2023
@brprice brprice merged commit 2ff4cb5 into main May 16, 2023
@brprice brprice deleted the brprice/rename-makecon branch May 16, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants