Use brandsUrl for dashboard brand icons and keep HACS fallback#927
Draft
usersaynoso wants to merge 2 commits intohacs:mainfrom
Draft
Use brandsUrl for dashboard brand icons and keep HACS fallback#927usersaynoso wants to merge 2 commits intohacs:mainfrom
usersaynoso wants to merge 2 commits intohacs:mainfrom
Conversation
ludeeus
requested changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
brandsUrl(...)helper for the primary dashboard brand icon URL/api/hacs/icon/{repository_id}when the hosted brand asset is missingbrands.home-assistant.ioURL pattern in HACS frontend codeDetails
This keeps the dashboard rendering change in
hacs/frontend, not inhacs/integration.The dashboard now builds the primary hosted icon URL through Home Assistant's existing
brandsUrl(...)helper and still falls back in the browser to the HACS endpoint when the hosted asset is missing.That keeps the frontend aligned with Home Assistant's own brand URL utility while preserving the existing fallback behavior expected by the companion integration change.
Testing
npx -y node@18 ./node_modules/gulp-cli/bin/gulp.js build-hacs