Fix #2: preserve zero custom position values#3
Open
hahacium wants to merge 12 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2.
The custom
positionobject logic previously used truthiness checks fortop,bottom,left, andright. That caused valid numeric0values to be treated as missing and replaced withauto.Fix
typeof ... !== 'undefined'checks.0while still defaulting omitted properties toauto.Verification
src/jquery.tips.jsinside theposition()method.master; the final file diff only changes the four position-property checks.package.jsonor an available test command.Risk
Low. The change is limited to custom object-based position handling and preserves the existing fallback behavior for
undefinedproperties.