Fix subpackage import incorrectly removed when sibling subpackage is used (#180)#322
Merged
hakancelikdev merged 4 commits intomainfrom Feb 18, 2026
Merged
Conversation
…used (#180) `import a.b` binds `a` in the namespace, so any `a.x.y` reference relies on that binding. `is_match_sub_packages` was comparing the import's root package against the full name string instead of just its first component, causing attribute usages like `urllib.parse.urlparse` to not match `import urllib.request`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When multiple imports share the same root package (e.g. import urllib.request and import urllib.parse), is_match_sub_packages was matching both to any urllib.* name usage, causing false negatives. Added _has_more_specific_import to check if another import provides a more direct path match for the name, so the sub-package fallback only applies when no specific import exists. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
import a.bbindsain the namespace, so anya.x.yreference relies on that binding.is_match_sub_packageswas comparing the import's root package against the full name string instead of just its first component, causing attribute usages likeurllib.parse.urlparseto not matchimport urllib.request.