Make typo in specs - #440
Merged
Merged
Conversation
c0e0ce1 ("Fix typo in assets.js (hanami#439)") fixed the typo, but the tests were testing against the same typo making the test suite fail. Fix the typo in the specs as well.
Contributor
|
ℹ️ Optional job failed: Ruby jruby |
Member
|
Thank you so much for cleaning this up for us, @PuercoPop! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c0e0ce1 ("Fix typo in assets.js (#439)") fixed the typo, but the tests were testing against the same typo making the test suite fail. Fix the typo in the specs as well.
Disclaimer: I didn't run the test suite locally as it the I didn't want to install the mysqlclient library to satisfy the mysql2 dependency. But based on the GitHub action output I'm ~confident that the change will fix the failures.