Add BitTiming class compatibility to Vector interface #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… vector-bit-timing # Conflicts: # can/interfaces/vector/canlib.py # can/interfaces/vector/vxlapi.py
Codecov Report
@@ Coverage Diff @@
## develop #650 +/- ##
===========================================
+ Coverage 68.57% 68.93% +0.36%
===========================================
Files 69 69
Lines 6227 6261 +34
===========================================
+ Hits 4270 4316 +46
+ Misses 1957 1945 -12 |
hardbyte
reviewed
Aug 6, 2019
can/interfaces/vector/canlib.py
Outdated
| self.canFdConf = xlclass.XLcanFdConf() | ||
| if bitrate: | ||
| self.canFdConf.arbitrationBitRate = ctypes.c_uint(bitrate) | ||
| if timing: |
Owner
There was a problem hiding this comment.
Can we refactor this out of the init and get back the canFdConf object? That should make the code more readible and make testing the corner cases a bit easier.
Collaborator
Author
There was a problem hiding this comment.
@hardbyte can you take another look? I implemented the changes you requested.
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation based on #625
BitTiming class takes precedence over the bitrate argument.
I did not remove the other bit timing arguments from init() and i did not add any deprecation warnings.
i tested this on a VN1610