#useservice-specific-secret#226
Merged
kapilgarg1996 merged 2 commits intoJun 26, 2026
Merged
Conversation
| # to the chart and its templates, including the app version. | ||
| # Versions are expected to follow Semantic Versioning (https://semver.org/) | ||
| version: 1.8.0 | ||
| version: 1.9.0 |
Collaborator
There was a problem hiding this comment.
bump patch version instead of minor version
| {{- $ := .ctx }} | ||
| {{- $globalServicesCtx := dict }} | ||
| {{- if and $.Values.global $.Values.global.services }} | ||
| {{- $globalServicesCtx = $.Values.global.services }} |
Collaborator
There was a problem hiding this comment.
This will pose a problem. When all services will be added in global context, their creds will become available to every service. Whereas, their creds should be available to the services which depend on them. So we need another filter below to filter out the required ones.
kapilgarg1996
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.