test: add regression coverage for CCM, STO, schema, and knowledge-graph paths#389
Closed
cursor[bot] wants to merge 3 commits into
Closed
test: add regression coverage for CCM, STO, schema, and knowledge-graph paths#389cursor[bot] wants to merge 3 commits into
cursor[bot] wants to merge 3 commits into
Conversation
- Add docs/coding-standards.md as the canonical architecture guide - Add tests/coding-standards/architecture.test.ts with 9 guardrail checks - Wire pnpm standards:check into CI alongside build/test/typecheck - Fix ToolsetName union missing knowledge-graph and semantic-layer - Remove HarnessClient imports from sto/ccm toolsets (use narrow interfaces) Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
…schema edge cases Add focused regression tests for recently merged production paths that lacked contract coverage: - cost_perspective.create preflight: settings merge, defaults, graceful degradation, and narrow CcmPreflightClient compatibility - security_exemption create/approve/reject preflights: required-field validation, PAT-derived IDs, and ACCOUNT scope param clearing - harness_schema nested lookup: wrapper-definition fallback and depth-cap miss Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
Add regression tests for knowledge-graph and semantic-layer paths that were merged without focused contract coverage: - hql_query validate: query_string aliases and envelope stripping - kg_type list: multi-bucket flattening, description truncation, object_kind filter - kg_type get: relationship_type dcs_enrichment join metadata without columnMappingMeta leaks - kg_queryable_type_summary: kinds/annotations filter body and tag projection Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
7 tasks
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds focused regression tests for recently merged production code paths where business risk was meaningful but contract coverage was thin.
Risky behavior now covered
CCM (
cost_perspective.createpreflight)viewPreferences(agent values win)viewState/viewType/viewVersiondefaultsaccount+requestonly)STO (
security_exemptionpreflights)requester_idbody.scoperequired, auto-derivedapprover_id, ACCOUNT scope elevation clears org/projectapprover_id_nextPageHintfilter preservation,skipCompactprojectionSchema (
harness_schema)extractLiveSchemaenvelope handlingKnowledge Graph / Semantic Layer (new in this iteration)
hql_queryvalidate:query_string/queryString/querybody aliases; projects only{ is_valid, errors }kg_typelist: multi-bucket flattening, description truncation,object_kind→filter.objectKindbodykg_typeget:relationship_typedcs_enrichmentjoin metadata withoutcolumnMappingMetaleakskg_queryable_type_summarylist:kinds/annotationsfilter body, description truncation, annotation tagsTest files added/updated
tests/registry/ccm-perspective-create.test.tstests/registry/sto-exemptions.test.tstests/tools/harness-schema-tool.test.tstests/registry/knowledge-graph.test.tstests/registry/gitops.test.tstests/resources/scope-check.test.tstests/utils/compact.test.tstests/coding-standards/architecture.test.tsWhy these tests materially reduce regression risk
Validation