Fix diagnose log download URL option parsing

[cursor]

Description

Fixes a crash/OOM regression in harness_diagnose where options.return_download_url only worked when provided as a boolean. Because options is an untyped record for MCP clients, callers can send "true"; before this fix that fell back to inline log fetching instead of signed URL-only mode for failed pipeline logs.

Type of Change

• Bug fix
• New feature
• Refactor
• Documentation
• Other

Checklist

• Tests pass
• Typecheck passes

Validation performed:

• pnpm exec vitest run tests/tools/diagnose/pipeline.test.ts -t "string return_download_url" failed before the fix and passed after it
• pnpm exec vitest run tests/tools/diagnose/pipeline.test.ts
• pnpm build
• pnpm docs:generate
• pnpm typecheck
• pnpm docs:check
• pnpm test

  

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[thisrohangupta]

Closing as stale: merge conflicts with main and work superseded by merged PRs (#447, #446, #449, #469, #440, #398, etc.) or duplicate agent-generated attempts. Reopen from a fresh branch if still needed.