test: add regression coverage for recent merges and identifier injection#399
Closed
cursor[bot] wants to merge 2 commits into
Closed
test: add regression coverage for recent merges and identifier injection#399cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
Add regression tests for harness_schema recursive definition lookup when only a non-schema-node wrapper exists, and when a nested schema node must win over a wrapper with the same name. Extend body-normalizer and harness_update coverage for environment YAML updates with injectIdentifier after unwrapKey. Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
… URLs Add regression tests for resolveLogDownloadUrl hostname rewriting on self-managed installs, kg_type list projection and object_kind filtering, relationship_type DCS enrichment on kg_type get, and requested_step_log download URLs when return_download_url is true. Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds focused regression tests for recently merged production changes where coverage was thin or missing.
Risky behavior now covered
harness_schemanested definition lookup (PR #368)Environment identifier injection (PR #328 follow-on)
buildBodyNormalizedinjectsenvironment_idafter unwrappingenvironment:YAML bodiesharness_updateforenvironmentsends unwrapped bodies with injected identifier to the APILog download URL rewrite (PR #358)
resolveLogDownloadUrlrewrites Harness CDN hostnames for self-managed installs (without fetching blob content)Semantic layer
kg_typelist/get (recent KG merges)object_kindfilter is passed as{ filter: { objectKind: [...] } }in the request bodykg_typeget surfaces DCS enrichment metadata onrelationship_typeresponsesDiagnose requested-step download URLs (PR #358)
requested_step_logreturnsdownload_url(not inline log content) whenreturn_download_url: trueTest files added/updated
tests/tools/harness-schema-tool.test.tstests/tools/tool-handlers.test.tstests/utils/body-normalizer.test.tstests/utils/log-resolver.test.tstests/registry/knowledge-graph.test.tstests/tools/diagnose/pipeline.test.tsWhy these tests reduce regression risk
These paths sit on high-blast-radius utilities (
body-normalizer,log-resolver) and agent-facing contracts (harness_schema,harness_update,harness_diagnose,kg_type). Failures would silently send wrong request shapes, leak internal schema wrappers, or return unusable log URLs on self-managed clusters — all of which are hard to catch without contract-level tests.Validation
311 tests passed.