chore: strengthen coding standards enforcement and fix scope violations#400
Closed
cursor[bot] wants to merge 3 commits into
Closed
chore: strengthen coding standards enforcement and fix scope violations#400cursor[bot] wants to merge 3 commits into
cursor[bot] wants to merge 3 commits into
Conversation
Update version across package.json, both manifest files, and the release-metadata test that keeps them in sync. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> AI-Session-Id: 1b46c8db-abe4-4e9f-a38b-750362ead8ac AI-Tool: claude-code AI-Model: unknown
…ctors Add regression tests for high-risk gaps in recent merges: - resolveLogDownloadUrl hostname rewrite for self-managed CDN URLs (PR #358) - HarnessClient.getCurrentUserId caching, dedup, and error paths (STO exemptions) - CCM GraphQL response extractors (views, breakdown, timeseries, summary, recommendations) - STO security_issue hint injection and pipeline_security_issue partition flattening Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
Expand automated architecture guardrails with registry contract tests, HarnessClient singleton checks, Zod v4 import validation, and legacy server.tool() detection. Fix toolset violations caught by the new checks: - database_instance: declare dbschema_id in identifierFields for nested gets - idp_entity/idp_workflow: use scopeOptional instead of manual scope query params - project: rely on injectOrgQueryFallback instead of redundant org_id mappings Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
7 tasks
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expands automated enforcement of the registry-driven MCP architecture documented in
docs/coding-standards.md, and fixes toolset violations surfaced by the new checks.Changes
New guardrails (
pnpm standards:check)Registry contract tests (
tests/coding-standards/registry-contracts.test.ts):scopeidentifierFields(empty array allowed for singleton gets)identifierFieldsoperationPolicy.riskandretryPolicyArchitecture test additions (
tests/coding-standards/architecture.test.ts):HarnessClientis only instantiated insrc/index.tszod/v4(never barezod)server.tool()registrationsToolset fixes (violations caught by new tests)
database_instance: adddbschema_idtoidentifierFieldsfor nested get pathsidp_entity/idp_workflow: usescopeOptionaland remove redundantorg_id/project_idquery param mappingsproject: useinjectOrgQueryFallbackconsistently instead of manualorg_id → orgIdentifiermappingsTest update
registry.test.ts: project list now correctly expects org fallback injection whenHARNESS_ORGis configuredVerification
pnpm standards:check— 17 tests passpnpm build— passpnpm typecheck— passpnpm test— 2159 tests pass