test: cover pipeline_v1 wait, read-only execute gate, policy eval remap, zip-csv#402
Draft
cursor[bot] wants to merge 2 commits into
Draft
test: cover pipeline_v1 wait, read-only execute gate, policy eval remap, zip-csv#402cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
…cident close Add focused regression tests for recently merged production paths with thin coverage: - harness_diagnose pipeline: return_download_url on requested_step_log for explicit step_id and auto-fetch paths; dedup when failed_step_logs already holds the URL - FME execute actions: fmeActionExtract wraps primitive kill/restore/archive responses so MCP output validation does not fail - harness_execute: successful security_exemption.approve remaps resource_id to exemption_id in the API path; FME kill remaps resource_id to feature_flag_name - incident close: response projection drops backend envelope/meta fields Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
…ap, zip-csv Add regression tests for high-risk paths not covered by PR #393: - pipeline_v1 wait: extractExecutionId from execution_details and top-level execution_id shapes; skip wait when ID is missing - HARNESS_READ_ONLY: pipeline.run blocked before elicitation (high_write risk) - policy_evaluation list: id → evaluation_id remap for compact-mode preservation - parseZipCsv/dashboardDataExtract: store and deflate ZIP parsing for dashboards Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risky behavior now covered
pipeline_v1+wait: true:extractExecutionIdmust read v1 trigger shapes (execution_details.execution_id, top-levelexecution_id) and poll via the shared execution endpoint. Without this, agents using v1 pipelines with server-side wait would silently skip polling (_wait.skipped).HARNESS_READ_ONLY+pipeline.run: Write-risk execute actions must be blocked before elicitation (mirrorsregistry.dispatchExecute()). Prevents prompting users to approve runs that can never execute.policy_evaluationlist extractor: Remaps APIid→evaluation_idso compact list mode preserves the stable identifier (compactor matches_id$, not bareid).parseZipCsv/dashboardDataExtract: Hand-rolled ZIP+CSV parser for dashboard data downloads — covers both store (method 0) and deflate (method 8) entries.Builds on PR #393 coverage (diagnose download URLs, FME primitives, execute remap, incident close).
Test files added/updated
tests/tools/tool-handlers.test.tstests/registry/governance.test.tsevaluation_idremaptests/utils/zip-csv.test.tsWhy these tests materially reduce regression risk
extractExecutionIdlines 82–86) with no prior handler-level coverage — a shape mismatch breaks the single-call wait contract agents rely on.harness_deleteandpipeline_dynamic_execution; standardpipeline.runis the most common write action and shares the same pre-dispatch gate.Validation