test: cover CCM perspective preflight, STO dispatch gaps, bodyWrapperKey, and dbops authoring#416
Closed
cursor[bot] wants to merge 3 commits into
Closed
test: cover CCM perspective preflight, STO dispatch gaps, bodyWrapperKey, and dbops authoring#416cursor[bot] wants to merge 3 commits into
cursor[bot] wants to merge 3 commits into
Conversation
…ctors Add regression tests for high-risk gaps in recent merges: - resolveLogDownloadUrl hostname rewrite for self-managed CDN URLs (PR #358) - HarnessClient.getCurrentUserId caching, dedup, and error paths (STO exemptions) - CCM GraphQL response extractors (views, breakdown, timeseries, summary, recommendations) - STO security_issue hint injection and pipeline_security_issue partition flattening Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
…jection - Add sto-exemption-actions.test.ts for create preflight, scope routing (/approve vs /promote), elevation input mutation, and approver injection - Extend registry.test.ts to lock accountIdentifier injection inside body.resourceGroup for access_control resource_group create Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
…Key, and dbops authoring Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risky behavior now covered
cost_perspective.createpreflight — settings fetch from/ng/api/settings,viewPreferencesdeep-merge (agent overrides win),viewState/viewType/viewVersiondefaults, and graceful degradation when settings API failsrejectdispatchExecute(path +approverIdinjection),createdispatch (camelCase body mapping +requesterId), list preflight strippingresource_scope/org_id/project_idscope keywords, andpipeline_security_stepextractor projectionbodyWrapperKeynested injection —organization,project, andconnectorcreate paths verify scope/fields land inside the wrapper object, not at the top leveldatabase_default_authoring_instanceanddatabase_llm_authoring_pipelinedispatch (path + query param construction)Test files added/updated
tests/registry/ccm-perspective-preflight.test.tstests/registry/sto-exemption-actions.test.tstests/registry/sto-exemptions.test.tstests/registry/sto-security-issue.test.tspipeline_security_stepprojection + dispatch)tests/registry/registry.test.tsbodyWrapperKeyfor org/project/connector)tests/registry/dbops.test.tsWhy these tests materially reduce regression risk
These paths sit on high-blast-radius agent workflows: CCM perspective creation silently wrong-filters every cost view; STO exemption list scope stripping prevents agents from abandoning account-level approvals; reject/create dispatch gaps would let approval-body regressions ship undetected;
bodyWrapperKeymis-injection causes 400s on core platform creates; and the dbops authoring endpoints are on the critical Accept & Commit skill chain.Validation