Fix: Internal server error #489
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: use new file name if old file name is empty (harrisoncramer#486) * fix: swap `file_name` and `old_file_name` in reviewer data * fix: jump to non-renamed files --------- Co-authored-by: Jakub F. Bortlík <jakub.bortlik@proton.me>
jakubbortlik
force-pushed
the
fix-internal-server-error
branch
from
7ad1c9b to
aedf084
Compare
Owner
|
I don't want to merge something directly into main, I've merged #485 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically a duplicate of #485, but rebased onto
main, in case you (@harrisoncramer) want to merge it directly without going throughdevelop. I'm not sure which way you prefer, but I'll be mostly unavailable for the rest of the week and I don't want to keep the users waiting for the fix (and I think it would be a pity to just revert thejump-to-reviewerfix).file_nameandold_file_namein reviewer data