This repository was archived by the owner on Sep 26, 2023. It is now read-only.
Hide empty options in usage output#55
Open
matiassingers wants to merge 2 commits intoharthur:masterfrom
Open
Conversation
|
Could someone review this PR? |
Author
|
bump 👍 |
Author
|
@harthur did you get a change to review this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you only specify options that are all set at
hidden: truethen the usage output will still display the empty options list.Current behavior:
Fixed output:
I edited the test that was currently expecting that empty options list, but it's just not very clean to add the options list if none of the options are shown. Seem weird.