Set explicit path to setpath in makejar#11
Open
jbuttery wants to merge 1 commit intoharvardinformatics:masterfrom
jbuttery:path-to-setpath
Open
Set explicit path to setpath in makejar#11jbuttery wants to merge 1 commit intoharvardinformatics:masterfrom jbuttery:path-to-setpath
jbuttery wants to merge 1 commit intoharvardinformatics:masterfrom
jbuttery:path-to-setpath
Conversation
Fixes an issue where makejar will fail if "." (the current directory) is not in the user's $PATH.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where makejar will fail if "." (the current directory) is not in the user's $PATH.
I didn't clutter up the actual commit message with this paragraph, but just FYI: the rationale behind changing this to an explicit path reference (of "./") is that having the current directory in $PATH is a security concern, albeit a rare one. The idea is that if a malicious user can get an executable with a common name (for example, a shell script named "ls") into a common location (such as a user's home directory), then it's fairly likely that the target will eventually run that executable; removing "." from $PATH avoids this.