Update lhv2 volume expansion doc#1048
Open
brandboat wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Harvester’s “Edit a Volume” documentation to refine guidance around online volume expansion with Longhorn and to improve readability across the unversioned and versioned docs.
Changes:
- Simplifies the Longhorn online expansion note to focus on the V1 Data Engine.
- Adds an informational note advising users to resolve Longhorn UI volume warnings before expanding.
- Fixes a malformed/indented numbered list item in the StorageClass restore steps.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| docs/volume/edit-volume.md | Updates Longhorn online expansion guidance and adds a warning note; fixes list formatting. |
| versioned_docs/version-v1.7/volume/edit-volume.md | Mirrors the Longhorn guidance update and list formatting fix for v1.7 docs. |
| versioned_docs/version-v1.8/volume/edit-volume.md | Mirrors the Longhorn guidance update and list formatting fix for v1.8 docs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Cooper Tseng <cooper.tseng@suse.com>
|
Comment on lines
+28
to
+34
| - **Longhorn**: Longhorn volumes support online volume expansion. | ||
|
|
||
| :::info | ||
|
|
||
| Before expanding a volume, check the volume status on the Volumes UI and resolve any warnings such as `Precheck new replica failed: disks are unavailable`. Volume expansion might not work as expected while these warnings are present. | ||
|
|
||
| ::: |
Contributor
There was a problem hiding this comment.
Suggested change
| - **Longhorn**: Longhorn volumes support online volume expansion. | |
| :::info | |
| Before expanding a volume, check the volume status on the Volumes UI and resolve any warnings such as `Precheck new replica failed: disks are unavailable`. Volume expansion might not work as expected while these warnings are present. | |
| ::: | |
| - **Longhorn**: Both the V1 and V2 Data Engines support online volume expansion. | |
| :::info important | |
| Before expanding a volume, check its status on the **Volumes** screen of the Harvester UI and resolve any warnings, such as `Precheck new replica failed: disks are unavailable`. Volume expansion may fail if these warnings are not addressed. | |
| ::: |
Comment on lines
+28
to
+34
| - **Longhorn**: Longhorn volumes support online volume expansion. | ||
|
|
||
| :::info | ||
|
|
||
| Before expanding a volume, check the volume status on the Volumes UI and resolve any warnings such as `Precheck new replica failed: disks are unavailable`. Volume expansion might not work as expected while these warnings are present. | ||
|
|
||
| ::: |
Contributor
There was a problem hiding this comment.
Suggested change
| - **Longhorn**: Longhorn volumes support online volume expansion. | |
| :::info | |
| Before expanding a volume, check the volume status on the Volumes UI and resolve any warnings such as `Precheck new replica failed: disks are unavailable`. Volume expansion might not work as expected while these warnings are present. | |
| ::: | |
| - **Longhorn**: Both the V1 and V2 Data Engines support online volume expansion. | |
| :::info important | |
| Before expanding a volume, check its status on the **Volumes** screen of the Harvester UI and resolve any warnings, such as `Precheck new replica failed: disks are unavailable`. Volume expansion may fail if these warnings are not addressed. | |
| ::: |
Comment on lines
+28
to
+34
| - **Longhorn**: Longhorn volumes support online volume expansion. | ||
|
|
||
| :::info | ||
|
|
||
| Before expanding a volume, check the volume status on the Volumes UI and resolve any warnings such as `Precheck new replica failed: disks are unavailable`. Volume expansion might not work as expected while these warnings are present. | ||
|
|
||
| ::: |
Contributor
There was a problem hiding this comment.
Suggested change
| - **Longhorn**: Longhorn volumes support online volume expansion. | |
| :::info | |
| Before expanding a volume, check the volume status on the Volumes UI and resolve any warnings such as `Precheck new replica failed: disks are unavailable`. Volume expansion might not work as expected while these warnings are present. | |
| ::: | |
| - **Longhorn**: Both the V1 and V2 Data Engines support online volume expansion. | |
| :::info important | |
| Before expanding a volume, check its status on the **Volumes** screen of the Harvester UI and resolve any warnings, such as `Precheck new replica failed: disks are unavailable`. Volume expansion may fail if these warnings are not addressed. | |
| ::: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doc pr for harvester/harvester#10597 (comment)