Skip to content

Revert "Add KVM source"#134

Closed
votdev wants to merge 1 commit into
mainfrom
revert-128-feat/kvm-source
Closed

Revert "Add KVM source"#134
votdev wants to merge 1 commit into
mainfrom
revert-128-feat/kvm-source

Conversation

@votdev
Copy link
Copy Markdown
Member

@votdev votdev commented Mar 5, 2026

Reverts #128 as discussed here: harvester/harvester#9948 (comment)

@votdev votdev requested a review from ibrokethecloud March 5, 2026 08:33
@votdev votdev self-assigned this Mar 5, 2026
Copilot AI review requested due to automatic review settings March 5, 2026 08:33
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the previously introduced KVM source support (#128), removing the KVM API/CRD/controller and associated integration test/setup code, and adjusting related helpers/dependencies accordingly.

Changes:

  • Remove KVMSource API types, generated controllers, CRD registration, controller logic, and KVM source implementation/tests.
  • Update VMware/OVA codepaths to use the renamed VMDK→RAW conversion helper and adjust hardware helper signature usage.
  • Update docs and module dependencies to reflect the removal of KVM functionality.

Reviewed changes

Copilot reviewed 23 out of 27 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/setup/setup_kvm.go Deletes KVM integration setup helpers.
tests/integration/suite_test.go Always starts vcsim (removes SKIP_VCSIM gating).
tests/integration/kvm_test.go Deletes KVM integration test suite.
pkg/source/vmware/client.go Switches VMDK conversion helper; minor error text change.
pkg/source/ova/client.go Switches VMDK conversion helper; updates NewHardware call.
pkg/source/openstack/client.go Moves raw image filename generation local; adds helper.
pkg/source/kvm/client_test.go Deletes KVM client unit tests.
pkg/source/kvm/client.go Deletes KVM source client implementation.
pkg/source/helper_test.go Updates tests for revised NewHardware signature.
pkg/source/helper.go Removes CPU model plumbing and shared raw filename helper; updates NewHardware signature.
pkg/qemu/qemu.go Renames conversion helper to VMDK-specific function; tweaks command setup.
pkg/qemu/gemu_test.go Updates test to call renamed conversion helper.
pkg/generated/controllers/migration.harvesterhci.io/v1beta1/kvmsource.go Removes generated KVMSource controller code.
pkg/generated/controllers/migration.harvesterhci.io/v1beta1/interface.go Removes KVMSource controller from generated interface.
pkg/crd/crd.go Removes KVMSource CRD registration.
pkg/controllers/migration/virtualmachine.go Removes KVM source kind handling and client wiring.
pkg/controllers/migration/kvm.go Removes KVM source controller implementation.
pkg/controllers/controllers.go Stops registering KVM controller and removes KVM from VM import controller wiring.
pkg/apis/migration.harvesterhci.io/v1beta1/zz_generated_register.go Removes KVMSource from scheme registration.
pkg/apis/migration.harvesterhci.io/v1beta1/zz_generated_list_types.go Removes KVMSource list type constructor/types.
pkg/apis/migration.harvesterhci.io/v1beta1/zz_generated_deepcopy.go Removes KVMSource deepcopy implementations.
pkg/apis/migration.harvesterhci.io/v1beta1/kvm.go Removes KVMSource API types/options.
pkg/apis/migration.harvesterhci.io/v1beta1/common.go Removes KindKVMSource constant.
go.mod Drops KVM-related deps (libvirt/sftp/crypto direct) and updates indirects.
go.sum Removes KVM-related sums and updates x/* versions accordingly.
README.md Removes KVM documentation/examples and related env var mentions.
.gitignore Stops ignoring .env.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/source/openstack/client.go
@votdev
Copy link
Copy Markdown
Member Author

votdev commented Mar 5, 2026

Superseded by #135

@votdev votdev closed this Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants