Revert "Add KVM source"#134
Closed
votdev wants to merge 1 commit into
Closed
Conversation
This reverts commit 4bb4e1e.
There was a problem hiding this comment.
Pull request overview
This PR reverts the previously introduced KVM source support (#128), removing the KVM API/CRD/controller and associated integration test/setup code, and adjusting related helpers/dependencies accordingly.
Changes:
- Remove KVMSource API types, generated controllers, CRD registration, controller logic, and KVM source implementation/tests.
- Update VMware/OVA codepaths to use the renamed VMDK→RAW conversion helper and adjust hardware helper signature usage.
- Update docs and module dependencies to reflect the removal of KVM functionality.
Reviewed changes
Copilot reviewed 23 out of 27 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/setup/setup_kvm.go | Deletes KVM integration setup helpers. |
| tests/integration/suite_test.go | Always starts vcsim (removes SKIP_VCSIM gating). |
| tests/integration/kvm_test.go | Deletes KVM integration test suite. |
| pkg/source/vmware/client.go | Switches VMDK conversion helper; minor error text change. |
| pkg/source/ova/client.go | Switches VMDK conversion helper; updates NewHardware call. |
| pkg/source/openstack/client.go | Moves raw image filename generation local; adds helper. |
| pkg/source/kvm/client_test.go | Deletes KVM client unit tests. |
| pkg/source/kvm/client.go | Deletes KVM source client implementation. |
| pkg/source/helper_test.go | Updates tests for revised NewHardware signature. |
| pkg/source/helper.go | Removes CPU model plumbing and shared raw filename helper; updates NewHardware signature. |
| pkg/qemu/qemu.go | Renames conversion helper to VMDK-specific function; tweaks command setup. |
| pkg/qemu/gemu_test.go | Updates test to call renamed conversion helper. |
| pkg/generated/controllers/migration.harvesterhci.io/v1beta1/kvmsource.go | Removes generated KVMSource controller code. |
| pkg/generated/controllers/migration.harvesterhci.io/v1beta1/interface.go | Removes KVMSource controller from generated interface. |
| pkg/crd/crd.go | Removes KVMSource CRD registration. |
| pkg/controllers/migration/virtualmachine.go | Removes KVM source kind handling and client wiring. |
| pkg/controllers/migration/kvm.go | Removes KVM source controller implementation. |
| pkg/controllers/controllers.go | Stops registering KVM controller and removes KVM from VM import controller wiring. |
| pkg/apis/migration.harvesterhci.io/v1beta1/zz_generated_register.go | Removes KVMSource from scheme registration. |
| pkg/apis/migration.harvesterhci.io/v1beta1/zz_generated_list_types.go | Removes KVMSource list type constructor/types. |
| pkg/apis/migration.harvesterhci.io/v1beta1/zz_generated_deepcopy.go | Removes KVMSource deepcopy implementations. |
| pkg/apis/migration.harvesterhci.io/v1beta1/kvm.go | Removes KVMSource API types/options. |
| pkg/apis/migration.harvesterhci.io/v1beta1/common.go | Removes KindKVMSource constant. |
| go.mod | Drops KVM-related deps (libvirt/sftp/crypto direct) and updates indirects. |
| go.sum | Removes KVM-related sums and updates x/* versions accordingly. |
| README.md | Removes KVM documentation/examples and related env var mentions. |
| .gitignore | Stops ignoring .env. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Superseded by #135 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #128 as discussed here: harvester/harvester#9948 (comment)