Fix incorrect disk sizes during VMware VM import (backport #140)#141
Merged
Conversation
Signed-off-by: Samuel Vasconcelos <samuel.vasconcelos@suse.com> (cherry picked from commit d540117)
Signed-off-by: Samuel Vasconcelos <samuel.vasconcelos@suse.com> (cherry picked from commit 2852e6a)
Signed-off-by: Samuel Vasconcelos <samuel.vasconcelos@suse.com> (cherry picked from commit 6869512)
Signed-off-by: Samuel Vasconcelos <samuel.vasconcelos@suse.com> (cherry picked from commit fd6f2e0)
ibrokethecloud
approved these changes
Mar 16, 2026
votdev
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
When importing virtual machines from VMware vCenter, the vm-import-controller determines disk sizes using nfc.LeaseItem.Size. In some VMware environments this value represents the total provisioned capacity of the VM, not the size of the individual disk.
As a result, each imported disk may incorrectly receive the aggregate VM size, causing PVCs to be over-provisioned and migrations to fail due to insufficient storage.
Solution:
Disk capacities are now determined using the VM hardware configuration retrieved from:
mo.VirtualMachine.Config.Hardware.DeviceFor each VirtualDisk, the code reads:VirtualDisk.CapacityInKB and maps disks to lease items using the busNumber.Related Issue:
harvester/harvester#10167
Test plan:
Observations
on the previous PR, we couldn't match the key, so we now matching the busNumber since is unique per controller instance in hardware model.
This is an automatic backport of pull request #140 done by Mergify.