Skip to content

Pin GH Actions to commit sha#146

Merged
votdev merged 1 commit into
harvester:mainfrom
votdev:pin-ci-actions-to-sha
Mar 26, 2026
Merged

Pin GH Actions to commit sha#146
votdev merged 1 commit into
harvester:mainfrom
votdev:pin-ci-actions-to-sha

Conversation

@votdev
Copy link
Copy Markdown
Member

@votdev votdev commented Mar 26, 2026

Related to: harvester/harvester#10279

Signed-off-by: Volker Theile <vtheile@suse.com>
@votdev votdev requested a review from ibrokethecloud March 26, 2026 08:42
@votdev votdev self-assigned this Mar 26, 2026
Copilot AI review requested due to automatic review settings March 26, 2026 08:42
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR strengthens the repository’s GitHub Actions supply-chain security posture by pinning third-party Actions to immutable commit SHAs (instead of floating tags/branches), in line with the goal in harvester/harvester#10279.

Changes:

  • Pin actions/checkout, Docker setup/login/build actions, and read-vault-secrets to commit SHAs in the reusable build workflow.
  • Pin Trivy scan and SARIF upload actions to commit SHAs in the Trivy scanning workflow.
  • Pin FOSSA and CodeQL-related actions to commit SHAs in their respective workflows.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
.github/workflows/template-build.yml Pins build/publish workflow action dependencies (checkout, docker actions, vault secret reader) to commit SHAs.
.github/workflows/scan.yml Pins Trivy scanning and SARIF upload actions (and checkout) to commit SHAs.
.github/workflows/fossa.yml Pins vault secret reader and FOSSA action to commit SHAs.
.github/workflows/codeql-analysis.yml Pins checkout and CodeQL actions (init/autobuild/analyze) to commit SHAs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Member

@martindekov martindekov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@votdev votdev merged commit 0658443 into harvester:main Mar 26, 2026
10 checks passed
@votdev votdev deleted the pin-ci-actions-to-sha branch March 26, 2026 08:54
@Vicente-Cheng
Copy link
Copy Markdown
Contributor

@Mergifyio backport v1.7

@mergify
Copy link
Copy Markdown

mergify Bot commented May 4, 2026

backport v1.7

✅ Backports have been created

Details

Cherry-pick of 0658443 has failed:

On branch mergify/bp/v1.7/pr-146
Your branch is up to date with 'origin/v1.7'.

You are currently cherry-picking commit 0658443.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/workflows/codeql-analysis.yml
	modified:   .github/workflows/scan.yml
	modified:   .github/workflows/template-build.yml

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   .github/workflows/fossa.yml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Vicente-Cheng pushed a commit that referenced this pull request May 4, 2026
Related to: harvester/harvester#10279

Signed-off-by: Volker Theile <vtheile@suse.com>
(cherry picked from commit 0658443)

# Conflicts:
#	.github/workflows/fossa.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants