Explicitly convert float to int for startTimer#129
Open
stanislavlevin wants to merge 1 commit intoharvimt:masterfrom
Open
Explicitly convert float to int for startTimer#129stanislavlevin wants to merge 1 commit intoharvimt:masterfrom
stanislavlevin wants to merge 1 commit intoharvimt:masterfrom
Conversation
As of Python3.10: > Builtin and extension functions that take integer arguments no longer accept Decimals, Fractions and other objects that can be converted to integers only with a loss (e.g. that have the int() method but do not have the index() method). (Contributed by Serhiy Storchaka in bpo-37999.) `startTimer` accepts only integers (milliseconds) and fails to implicitly convert floats. Fixes: harvimt#128 Signed-off-by: Stanislav Levin <slev@altlinux.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of Python3.10:
startTimeraccepts only integers (milliseconds) and fails toimplicitly convert floats.
Fixes: #128