fix(blocknode): honor --values plugins.names via "no override" preset

[alex-au]

Description

A block-node --values file that sets plugins.names was silently ignored on an
interactive install. The plugin-preset prompt always pre-selected a preset (default
tier1-lfh) and offered no "use my values file" option, so the resolved plugin list was
never empty — and injectPluginsConfig then overwrote the values-file plugins.names
after the deep-merge (PR #703) had correctly let it win. Operators who set plugins.names
in --values got the preset bundle deployed instead, a silent divergence between intent
and what actually ran.

This PR implements the precedence flags/TUI (explicit) > values.yaml > chart default
by letting the resolution produce an empty plugin list when the operator did not
explicitly choose plugins. An empty list already makes injectPluginsConfig a no-op, so
the merged values-file (or chart-default) plugins.names survives untouched.
injectPluginsConfig and mergeValues are unchanged.

Files changed

File	Change
internal/blocknode/blocknode_plugins.go	Add PresetNone = "none" + label + menu entry; deliberately not in any Presets map → IsKnownPreset("none")=false, resolves to ""
internal/blocknode/values.go	Add exported ValuesFileDefinesPlugins(path) (error-tolerant; scalar or YAML-sequence plugins.names)
internal/ui/prompt/blocknode.go	RunPluginPresetPrompts gains a valuesFile param; smart-defaults to PresetNone when the file defines plugins.names
cmd/cli/commands/block/node/init.go	Pass flagValuesFile to the prompt; upgrade re-resolve guard now && !ValuesFileDefinesPlugins(...)
pkg/models/inputs.go, cmd/cli/commands/common/flags_blocknode.go, docs/quickstart.md	Document none on PluginPreset / the --plugin-preset flag
internal/blocknode/blocknode_plugins_test.go	Tests for the PresetNone registry contract and ValuesFileDefinesPlugins

Behavior

• Interactive install with -f defining plugins.names → prompt now lists and
  pre-selects "Use Values File / Chart Default"; accepting it deploys the file's list.
• --plugins / --plugin-preset still suppress the prompt and win (flags beat the file).
• --plugin-preset none is a valid scripted "no override" value.
• No -f plugins / no explicit choice → unchanged (tier1-lfh default; scripted → chart default).
• upgrade: a values-managed plugins.names is no longer clobbered by the saved-state
  re-resolve, while the chart-version plugin rename still applies when plugins are not
  values-managed.

Review guide

Code-review checklist

• PresetNone is absent from every blockNodePluginHistory[*].Presets map →
  IsKnownPreset("none")==false, PluginListForPreset("none",…)==""
  (internal/blocknode/blocknode_plugins.go).
• Selecting PresetNone leaves *flagPlugins empty — the existing Pass-2
  != PresetCustom early return handles it (internal/ui/prompt/blocknode.go).
• init.go resolution: PresetNone → pluginList=="", so neither the
  --plugins required error nor the custom promotion triggers
  (cmd/cli/commands/block/node/init.go resolve block).
• Upgrade guard skips the state re-resolve only when the values file defines
  plugins; otherwise the 0.35 s3-archive → cloud-storage-* rename still applies.
• Smart default overrides the tier1-lfh/state default only when the values file
  actually defines plugins.names (common no--f case unchanged).
• injectPluginsConfig / mergeValues untouched.

Test commands

# macOS-runnable unit tests (core of the fix)
go test ./internal/blocknode/... ./internal/ui/prompt/... ./pkg/models/...
go test ./internal/blocknode/ -run 'PresetNone|ValuesFileDefinesPlugins|AvailablePresets' -v

# Full suite incl. Linux-only packages — run in the UTM VM
task vm:test:unit
task vm:test:integration TEST_NAME='^Test.*Install.*$'

Manual UAT (VM) — verified end-to-end ✅

1. Create a values file with a plugin list distinct from every built-in preset — the
   full tier1-lfh list minus backfill:

   printf 'plugins:\n  names: "facility-messaging,block-access-service,health,server-status,stream-publisher,stream-subscriber,verification,blocks-file-historic,blocks-file-recent"\n' > /tmp/myvalues.yaml

   Note: a very sparse plugin set (e.g. just health,verification) can make the
   block-node server fail its /healthz/readyz probe and never come up, causing Helm's
   --atomic install to time out and roll back the whole release — a property of that
   plugin combination, not of this fix. Confirmed via kubectl get events -n <ns>:
   the pod pulled the image and started, but block-node-server never opened its port
   in time. Use a fuller-but-still-custom list (as above) to get a stable release you
   can inspect with helm get values.

2. Self-install the provisioner once, then run the interactive install (use the installed
   binary on PATH, not ./bin/...):

   sudo solo-provisioner install
   sudo solo-provisioner block node install -p local \
     --namespace bn --release-name bn --chart-version 0.37.0 \
     --base-path /opt/bn --historic-retention 0 --recent-retention 96000 \
     -f /tmp/myvalues.yaml

   (0.37.0 is the newest chart version published to ghcr.io/hiero-ledger/hiero-block-node
   at time of writing; pick whatever is current.)
3. Expected — smart default: the "Block Node Plugin Preset" prompt now lists a fourth
   option and pre-selects it:

   ┃ Block Node Plugin Preset
   ┃   Tier 1 — Local Full History  (blocks stored on local disk)
   ┃   Tier 1 — Remote Full History  (blocks stored in cloud storage)
   ┃   Custom  (select individual plugins)
   ┃ > Use Values File / Chart Default  (no override)
   

4. Accept "Use Values File / Chart Default". Confirm the values file won:

   helm get values bn -n bn -a | grep -A1 '^plugins:'
   # observed: names: facility-messaging,block-access-service,health,server-status,
   #   stream-publisher,stream-subscriber,verification,blocks-file-historic,blocks-file-recent
   # (9 plugins — NOT the 10-plugin tier1-lfh bundle, which also includes backfill)

5. Flags still win: re-run adding --plugin-preset tier1-lfh (or --plugins a,b) — no
   prompt appears and the preset/flag list is deployed, overriding the file.
6. Unchanged default: re-run with a -f file that has no plugins.names (or no
   -f) — the prompt defaults to Tier 1 — Local Full History as before.
7. Scripted no-override: --force --plugin-preset none -f /tmp/myvalues.yaml deploys
   the file's plugins.names with no prompt.

Risks / rollback

Low. The interactive default only changes when the --values file defines plugins.names;
all other flows are unchanged, and injectPluginsConfig/mergeValues are untouched.
Rollback = revert the PresetNone additions, the prompt smart-default line, and the
upgrade-guard clause.

Stacking note

Builds on merged PR #703 (deep-merge custom --values over the embedded profile base),
which is what lets a values-file plugins.names survive the merge in the first place.

Related Issues

• Closes Block-node plugins.names from --values is ignored; honor precedence flags/TUI > values.yaml > chart default #731

[swirlds-automation]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[AlfredoG87]

LGTM

[Copilot]

Pull request overview

This PR fixes interactive block-node installs/upgrades where an operator-provided --values file setting plugins.names could be silently overridden by the TUI plugin preset selection. It introduces a “no override” preset (none) and a values-file probe so that (when plugins.names is managed via --values) the prompt defaults to not injecting a preset-derived plugin list, preserving Helm values precedence.

Changes:

• Add a PresetNone = "none" option to the plugin preset prompt that resolves to an empty plugin list (so injectPluginsConfig becomes a no-op).
• Add ValuesFileDefinesPlugins(path) and use it to smart-default the interactive preset to “none” when the --values file defines plugins.names, and to guard upgrade re-resolution from state.
• Update CLI/docs/model comments and add unit tests for the new preset contract + values-file detection.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
pkg/models/inputs.go	Document none as a “no override” plugin-preset value.
internal/ui/prompt/blocknode.go	Add valuesFile param and smart-default preset to none when the values file defines plugins.names.
internal/blocknode/values.go	Add ValuesFileDefinesPlugins helper used by prompt and upgrade guard.
internal/blocknode/blocknode_plugins.go	Add PresetNone, label, and ordered menu entry; keep it out of preset maps so it resolves to empty list.
internal/blocknode/blocknode_plugins_test.go	Add tests for PresetNone contract and ValuesFileDefinesPlugins.
cmd/cli/commands/block/node/init.go	Pass --values path into prompt; skip upgrade re-resolve when values file defines plugins.
cmd/cli/commands/common/flags_blocknode.go	Update --plugin-preset flag help text to include none.
docs/quickstart.md	Document --plugin-preset none semantics in quickstart flags table.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.