This repository was archived by the owner on Dec 6, 2023. It is now read-only.
Correctly set file ownership on startup#98
Open
DanielFallon wants to merge 1 commit intohashicorp:mainfrom
Open
Correctly set file ownership on startup#98DanielFallon wants to merge 1 commit intohashicorp:mainfrom
DanielFallon wants to merge 1 commit intohashicorp:mainfrom
Conversation
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Daniel Fallon seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
|
This would also fix #175 |
|
@stevendpclark may you can have a look at this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ "$(stat -c %u /vault/config)" != "$(id -u vault)" ]does not correctly test "If the config dir is bind mounted"This will break if the user starts vault, then copies an additional file into the bind mounted config directory and then restarts the container. While the folder
/vault/configwill be still owned by vault:vault after the container is restarted, the newly created files will not mirror those permissions unless the sticky bit was set on the directory AND the user didn't inadvertently change them.The result looks something like this: