Fix zero timestamp in stderr where upstream has time disabled#263
Open
binaek wants to merge 1 commit intohashicorp:mainfrom
Open
Fix zero timestamp in stderr where upstream has time disabled#263binaek wants to merge 1 commit intohashicorp:mainfrom
binaek wants to merge 1 commit intohashicorp:mainfrom
Conversation
|
|
|
Hi @binaek, can you add the scenario where you were facing this issue and testing for the same in description ? Also please add a test case for the change |
|
This happens if the upstream caller has DisableTime set to true |
Author
|
@bdwyertech thanks for the comment. I think I had left it in the code... |
Yep, I bumped into the same issue. I've been running my own fork for a year or so... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.