refactor(protobuf): update protobuf imports#340
refactor(protobuf): update protobuf imports#340antegral wants to merge 1 commit intohashicorp:mainfrom
Conversation
|
|
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
| require ( | ||
| github.com/bufbuild/protocompile v0.4.0 // indirect | ||
| github.com/fatih/color v1.7.0 // indirect | ||
| github.com/golang/protobuf v1.5.3 // indirect |
There was a problem hiding this comment.
Was this manually added or was it added as a part of go mod tidy ?
There was a problem hiding this comment.
See diff, removed from line 6, moved to indirect. It meant it's no longer being directly used, coinciding with require line removals in below .go files.
I wouldn't concern with this change.
There was a problem hiding this comment.
Yes, it is not being used directly. But running go mod tidy will check in case it can be removed as indirect dependency as well
Ran it locally, seems to fine
|
Please rebase the PR then we should be good for merging it 🚀 |
3 participants
Summary
Following this issue, update deprecated protobuf imports to
google.golang.org/protobuf.Closes #338 (confirmed that the test passed in 1.24.0)