[chore] : Bump the go group across 1 directory with 4 updates#371
[chore] : Bump the go group across 1 directory with 4 updates#371dependabot[bot] wants to merge 2 commits intomainfrom
Conversation
Bumps the go group with 2 updates in the / directory: [github.com/jhump/protoreflect](https://github.com/jhump/protoreflect) and [github.com/oklog/run](https://github.com/oklog/run). Updates `github.com/jhump/protoreflect` from 1.17.0 to 1.18.0 - [Release notes](https://github.com/jhump/protoreflect/releases) - [Commits](jhump/protoreflect@v1.17.0...v1.18.0) Updates `github.com/oklog/run` from 1.1.0 to 1.2.0 - [Release notes](https://github.com/oklog/run/releases) - [Commits](oklog/run@v1.1.0...v1.2.0) Updates `google.golang.org/grpc` from 1.61.0 to 1.66.2 - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.61.0...v1.66.2) Updates `google.golang.org/protobuf` from 1.36.6 to 1.36.11 --- updated-dependencies: - dependency-name: github.com/jhump/protoreflect dependency-version: 1.18.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go - dependency-name: github.com/oklog/run dependency-version: 1.2.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go - dependency-name: google.golang.org/grpc dependency-version: 1.66.2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go - dependency-name: google.golang.org/protobuf dependency-version: 1.36.11 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: go ... Signed-off-by: dependabot[bot] <support@github.com>
55fb88c to
e9b3d26
Compare
sonamtenzin2
left a comment
There was a problem hiding this comment.
Changed grpc.Dial to grpc.NewClient becuase of depreciation errors
| // Connect. Note the first parameter is unused because we use a custom | ||
| // dialer that has the state to see the address. | ||
| conn, err := grpc.Dial("unused", opts...) | ||
| conn, err := grpc.NewClient("passthrough:///unused", opts...) |
There was a problem hiding this comment.
grpc.Dial is depreciated and it is recommended to use NewClient instead. Both the methods are pretty much similar based on the godocs, with only a minor difference described below.
NewClient requires passthrough:/// to be added in the address in order to let the custom dialer do its work. This is not required in Dial or DialContext because the passthrough parameter is already defined inside those methods
| conn, err := grpc.Dial( | ||
| conn, err := grpc.NewClient( | ||
| l.Addr().String(), | ||
| grpc.WithBlock(), |
There was a problem hiding this comment.
grpc.WithBlock() is not supported as a parameter for grpc.NewClient
| if !conn.WaitForStateChange(ctx, state) { | ||
| t.Fatalf("failed to establish connection, final state: %v", conn.GetState()) | ||
| } | ||
| } |
There was a problem hiding this comment.
The NewClient has the property that it will stay idle unless a connection is explicitly established. conn.Connect() establishes this connection.
A new logic for blocking was added for it because otherwise the listener was closing before the connection was completed. The above logic is inspired by the existing code present in grpc library for Dial method. Although we have added a for loop, the code is not busy waiting because WaitForStateChange method is blocking in nature.
A better way will be to pass the listener as a parmeter in TestGRPCConn and then the listener should be closed later by the calling function. This will prevent the connection and waiting logic. But, the method has been used in other code bases as an external function so chose this approach
Added lint fix by changing
grpc.Dialtogrpc.NewClient. The changes were verified with unit test casesBumps the go group with 2 updates in the / directory: github.com/jhump/protoreflect and github.com/oklog/run.
Updates
github.com/jhump/protoreflectfrom 1.17.0 to 1.18.0Release notes
Sourced from github.com/jhump/protoreflect's releases.
Commits
19645ddAdd a test case to make sure experimental Edition 2024 support is usable (#648)3297f00Fixes for one last (🤞) v1 release (#646)225aff8Update README to mention purpose of this branch (#625)9d27593update to same CI config as main (v2) (#624)8f5fd1dshare source code info store w/ v2Updates
github.com/oklog/runfrom 1.1.0 to 1.2.0Release notes
Sourced from github.com/oklog/run's releases.
Commits
c769e58Update GitHub Actions test.yaml workflow (#38)eee6e04Fix bug in SignalHandler (#27)145e764Update README.mddf79bd8Update README.mdf5dcbf4Update test.yamldaf88edSignalError fixes, ContextHandler (#25)c709688Deregister signal channel (#16)0c58000LICENSE: properly date/attributeUpdates
google.golang.org/grpcfrom 1.61.0 to 1.66.2Release notes
Sourced from google.golang.org/grpc's releases.
... (truncated)
Commits
d0bf90aChange version to 1.66.2 (#7620)c84da66Cherry pick #7595 to v1.66.x release branch (#7621)12487c8Cherry pick #7571 and #7579 to v1.66.x release branch (#7616)7185cf4Change to version 1.66.2-dev (#7615)cb81df6Change to patch release 1.66.1 (#7603)ecb3e1aChange version to 1.66.1-dev (#7519)00d3ec8Change version to 1.66.0 (#7518)973e3dcxdsclient: Populate total_issued_requests count in LRS load reports (#7544) (...8e3596ccherry-pick #7557 to v1.66.x branch (#7564)62baa5fcherry-pick #7356 to v1.66.x branch (#7546)Updates
google.golang.org/protobuffrom 1.36.6 to 1.36.11Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions