Remove redundant square braces for ipv6 with latest sdk version#143
Open
vin01 wants to merge 1 commit intohashicorp:mainfrom
Open
Remove redundant square braces for ipv6 with latest sdk version#143vin01 wants to merge 1 commit intohashicorp:mainfrom
vin01 wants to merge 1 commit intohashicorp:mainfrom
Conversation
zadjadr
reviewed
Nov 21, 2025
| var addr string | ||
| address := element.(map[string]interface{}) | ||
| address_value := address["addr"].(string) | ||
| if address["OS-EXT-IPS:type"] == "floating" { |
There was a problem hiding this comment.
I think we can get rid of this entire if else workflow now
Author
There was a problem hiding this comment.
I think that is needed to use the right precedence (ipv6 > ipv4) and also if explicit config option forces use of v4 or v6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Until the latest release of plugin, it was using the older SDK version in release 1.1.2 (Feb 29, 2024). In 1.1.3 however the latest SDK version is in use which includes proper handling of ipv6 addresses directly in the SDK itself: https://github.com/hashicorp/packer-plugin-sdk/pull/246/files
This breaks ipv6 connectivity for openstack plugin because address is returned with square braces around it.
I have kept if/else structure the same to ensure precedence still is given to ipv6 if present and returned first. No logic change.
Error messages from 1.1.3 using latest plugin sdk showing redundant square braces
Changes to Security Controls
No changes related to security controls.