Close statements after use#53
Merged
Merged
Conversation
dmjio
approved these changes
Oct 16, 2025
Collaborator
dmjio
left a comment
There was a problem hiding this comment.
Nice, maybe it's worth making a withStatement function that automatically performs closeStatement (like withHandle). I can update the nix hash in a separate PR.
withStmt conn sql action = do
stmt <- prepareStmt conn sql
result <- action stmt
closeStatement stmt
pure result
dmjio
added a commit
that referenced
this pull request
Oct 26, 2025
Open
Collaborator
|
@apkhandkar sorry, I should not have merged this, I assumed this was something you were upstreaming that was a fix.
If I get bandwidth I'll come back to the test failures, or if you'd like to upstream the fix. |
dmjio
added a commit
that referenced
this pull request
Oct 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not doing so was leading to a "maximum open cursors exceeded" error.