You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Instead of overriding those functions, you should be able to listen to "add" signals emitted by L.notebook.get("notes").
Also, while this is a stop-gap solution, it's really inefficient. A full sync (what you are doing here) first downloads all of the notes and then pushes the changed notes to the server. Instead, you should only push updated notes. You could do this by calling L.server.pushNotes(). However, if you do this, you will have to handle note conflicts.
Currently, L.server.commitNotes() only reports errors on the console, it doesn't return an error status if a note fails to push because (a) this can only happen if some other instance updated the note on the server since this instance last pulled the note and (b) it'll just get around to syncing that note on the next sync.
So you should probably modify commitNotes to return some "temporary failure" status to pushNotes (which can in turn call the error callback). You can then handle this transient error by triggering a full sync.
Stebalien
changed the title
[Web] Syncs notes when a note is saved or edited.
Syncs notes when a note is saved or edited.
Feb 6, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #200