Skip to content

Update README.md#113

Open
Gabrail wants to merge 1 commit into
hcengineering:mainfrom
Gabrail:patch-1
Open

Update README.md#113
Gabrail wants to merge 1 commit into
hcengineering:mainfrom
Gabrail:patch-1

Conversation

@Gabrail

@Gabrail Gabrail commented Dec 24, 2024

Copy link
Copy Markdown

remove the added config for LOVE_ENDPOINT under front section, also mention to add the LIVEKIT_WS with WSS prefix

remove the added config for LOVE_ENDPOINT under front section, also mention to add the LIVEKIT_WS with WSS prefix

Signed-off-by: Mo Gabrail <soul.gebreel@gmail.com>
@sh4hzaib

sh4hzaib commented Jan 16, 2025

Copy link
Copy Markdown

I want to mention couple of things in section "Love Service (Audio & Video calls)"

  • on step 2, the image section should be like

    "image: hardcoreeng/love:${HULY_VERSION}"
    this should make sure consistent version.

  • secret should be picked from huly.conf
    "SECRET=${SECRET}"

At first glance, I thought secret is something like a secret variable, that might be used for any encryption and generated separately. It took a while to go through other issues and code to observe what really should be here.

Comment thread README.md
...
environment:
- LIVEKIT_WS=<LIVEKIT_HOST>
- LOVE_ENDPOINT=http://love:8096

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOVE_ENDPOINT is required here

@aonnikov aonnikov closed this Aug 13, 2025
@lexiv0re lexiv0re reopened this Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants