fix: preserve created workspace id in restore-workspace#313
Open
mc-putchar wants to merge 2 commits into
Open
Conversation
|
Connected to Huly®: SELFH-313 |
| fi | ||
|
|
||
| echo -e "\n\033[1;34m[3/4] Setting $EMAIL role to OWNER for $WS_ID...\033[0m" | ||
| if ! /run-tool.sh set-user-role "$EMAIL" "$WS_ID" OWNER; then |
Member
There was a problem hiding this comment.
Looks like this command will not work due to the absolute path in /run-tool.sh.
I suggest to replace it with ./run-tool.sh.
| echo -e "\033[1;33massign-workspace failed - the owner may already be assigned. Continuing.\033[0m" | ||
| fi | ||
|
|
||
| echo -e "\n\033[1;34m[3/4] Setting $EMAIL role to OWNER for $WS_ID...\033[0m" |
Member
There was a problem hiding this comment.
[minor] Duplicate step labels 3/4:
[3/4] Assigning $EMAIL
[3/4] Setting $EMAIL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an issue in the workspace restoration script where the newly generated workspace UUID was lost, causing downstream initialization steps to fail.
Changes:
workspaceUuidfrom the command output.assign-workspacetool command to properly pass the admin email first, followed by the workspace ID.backup-restoresteps, preserving the original behavior in case--skip-workspaceargument is passed.