fix(text-markdown): serialize inline comment marks#19
Open
dearlordylord wants to merge 1 commit into
Open
Conversation
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix markdown serialization for Huly
inline-commentmarks by preserving the marked text and omitting the editor-only comment metadata.This is intentionally not isomorphic: markdown has no native representation for Huly inline comment thread metadata, and other markdown conversions in this package are already semantic/lossy rather than exact markup JSON round-trips.
The issue is introduced in dependent packages around https://github.com/hcengineering/platform/blob/2158661df5cca7e7ff43fe06d2438a20b6cbce98/plugins/text-editor-resources/src/components/extension/inlineComment.ts#L826-L828 - so it seems text-markdown was added in other parts of the system but not in .core
likely fixes hcengineering/platform#9314
prompted by dearlordylord/huly-mcp#71 user problem in the MCP. It's likely cleaner to be solved upstream (here)