Skip to content

Conversation

@halotroop2288
Copy link

@halotroop2288 halotroop2288 commented Mar 4, 2025

Using my limited knowledge to fix smaller issues. 💪🏻

Fixes

Additional Notes

I made a few changes as suggested by the IDE

  • inline is implied by template
  • else is redundant after return
  • return value; is unreachable after assert(false && ...)

@halotroop2288 halotroop2288 changed the title Compiler-specific ByteSwap Fix small issues Mar 4, 2025
halotroop2288 and others added 4 commits March 4, 2025 02:26
Devkit key is all zeros, unlike the all-precious retail key.
Thanks to @ran-j for pointing this out!
@blueskythlikesclouds
Copy link
Member

blueskythlikesclouds commented Apr 4, 2025

Hmm, I couldn't get the devkit code to execute, is the check correct?

Xenia seems to try two times and goes with whichever manages to succeed: https://github.com/xenia-project/xenia/blob/3d30b2eec3ab1f83140b09745bee881fb5d5dde2/src/xenia/cpu/xex_module.cc#L938

Maybe to validate that the decryption succeeded, it could try to validate the PE header, but I don't know if that's something that'd work consistently across games.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

What Am I doing wrong? Typo in the README

3 participants