proof(windows): isolate SID70 confinement effect v2#52
Closed
marksverdhei wants to merge 12 commits into
Closed
Conversation
Reconcile the queued dependency updates across Cargo, Bazel, pnpm, and CI metadata. Harden timing-sensitive integration fixtures, add deterministic cross-call synchronization, and update strict-clippy compatibility without changing production behavior beyond the dependency refresh. Acting-Agent: chloe
Run non-cancelled post-merge Windows coverage on both integration branches and update the fork guide to consistently name clanker as the default branch. Acting-Agent: chloe
Normalize Windows paths in app-server and avatar assertions, give shell-command unit tests hosted-runner headroom, and use the Restricted Code SID instead of Everyone for restricted-token initialization without weakening world-writable path isolation. Acting-Agent: chloe
Use a temporary absolute project path for the memory scope fixture and compensate path-normalized TUI snapshots for the Windows drive-prefix width before rendering. Linux snapshot geometry remains unchanged. Acting-Agent: Chloe
Exercise the actual WRITE_RESTRICTED token against protected ACL fixtures. Everyone-only write access must remain denied, while an ACL explicitly granting Restricted Code must allow the hosted-runner compatibility path. Acting-Agent: Chloe
Guard the restricted-token impersonation so a failing assertion cannot leave the Windows test thread impersonated. Explicit successful reversion remains checked. Acting-Agent: Chloe
Use the Write Restricted Code SID for write-restricted process compatibility without allowing Everyone-only writes. Normalize Windows fixtures centrally and give asynchronous hook, rollback, and ConPTY tests deterministic readiness and deadline contracts. Acting-Agent: chloe
Resolve private desktop names from the process window station, inherit the caller desktop for default launches, and grant the restricted logon SID the station and desktop rights required by user32 initialization.\n\nActing-Agent: chloe
Canonicalize the temporary home before deriving a project key so Windows path identity matches the storage contract.\n\nActing-Agent: chloe
Leave the interactive WinSta0 DACL untouched and grant noninteractive service stations only the documented read rights needed to open the station. Keep screen, clipboard, global-atom, and write access outside the sandbox token while retaining the private desktop grant.\n\nRegisterWindowMessage behavior under a restricted service-station token remains unvalidated; the mask test pins the intended boundary but is not behavioral proof of that payload.\n\nActing-Agent: Chloe
Exercise the non-private restricted-token launch path with PowerShell on the caller's inherited desktop. Preserve the prior STATUS_DLL_INIT_FAILED warning next to lpDesktop so the unsafe WinSta0 hardcode is not reintroduced without understanding the original failure mode.\n\nActing-Agent: Chloe
Remove only the Write Restricted Code SID from the exact PR #46 candidate while retaining the executable workspace-confinement regression unchanged. This temporary branch determines whether SID70 causes the observed outside-workspace deletion or merely correlates with it.\n\nActing-Agent: Chloe
Contributor
Author
|
Diagnostic-only proof branch. The finding has been incorporated into #46's final reviewed Windows isolation design; closing without merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-merge evidence branch.
Removes only SID70 from the exact PR #46 candidate parent while retaining the real inherited-ACL confinement test. Evidence is valid only if the process executes and both the outside file and protected .git survive; startup failure is non-evidence.
Acting-Agent: chloe