Fix NullPointerException when logging an MVEL action failure (#67)#152
Open
amenski wants to merge 1 commit into
Open
Fix NullPointerException when logging an MVEL action failure (#67)#152amenski wants to merge 1 commit into
amenski wants to merge 1 commit into
Conversation
MvelActionImpl logged failures with e.getCause().getMessage(), which threw a NullPointerException whenever the caught RuntimeException had no cause, masking the original error. Apply the same null-safe logging already used by MvelConditionImpl.
amenski
force-pushed
the
fix/issue-67-mvel-npe
branch
from
2265d28 to
4ab2925
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MvelActionImpllogged action failures withe.getCause().getMessage(). When the caughtRuntimeExceptionhad no cause, this threw aNullPointerExceptioninside the catch block, masking the original error.This applies the same null-safe logging already used by
MvelConditionImpl.Fixes #67.
Test plan
MvelActionImplTest- verified to fail on the original code and pass with the fix.