This repository was archived by the owner on Mar 5, 2024. It is now read-only.
Open
Conversation
xandkar
approved these changes
May 18, 2022
Contributor
xandkar
left a comment
xandkar
left a comment
There was a problem hiding this comment.
Looks good.
Left some minor comments. Also, in general, I still think that just calling digraph_utils:components/1 on the topology would be much easier to understand.
marcsugiyama
force-pushed
the
sugiyama/fix-diff_test
branch
from
d723ec9 to
b32b2e0
Compare
xandkar
reviewed
May 20, 2022
| % NetworkMap - #{ConnectedToNode => [ConnectedFromNode]} | ||
| find_connected_node_pair({_, Node, Iter}, AddrToNodeMap, NetworkMap) -> | ||
| GossipPeerNodes = | ||
| [ConnectedNode | _] = |
Contributor
There was a problem hiding this comment.
If we're only picking one, maybe no need to addr_to_node all of them, but just lookup the picked one?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
diff_testcallsblockchain_gossip_handler:add_blockwith the Swarm instead of the SwarmTID which results in abadargfromets. This PR changes the call to pass the table id instead, fixing the test error.This PR also includes some code cleanup as suggested by @xandkar .