Merged
Conversation
georgewhewell
force-pushed
the
grw/feat/chat
branch
6 times, most recently
from
9059cc7 to
5f31a65
Compare
Add typed OpenAI, Anthropic, and plain completion types with only the fields we actually support, plus shared prompt-preparation and detokenization helpers. Replace the old serve trait glue with a concrete ModelEngine generation API so local inference, examples, and downstream consumers use the same typed surface.
Demonstrate the new typed request and response surfaces with a tiny_http server that serves OpenAI-, Anthropic-, and plain-compatible endpoints. Keep the example separate from the runtime refactor so the library cutover stays focused and the serving layer is easy to review on its own.
georgewhewell
force-pushed
the
grw/feat/chat
branch
from
5f31a65 to
a53accf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sorry for the huge PR-