Post with publishDate and date appears twice.#3
Open
jkuebart wants to merge 1 commit intohellatan:masterfrom
Open
Post with publishDate and date appears twice.#3jkuebart wants to merge 1 commit intohellatan:masterfrom
jkuebart wants to merge 1 commit intohellatan:masterfrom
Conversation
If a post has `publishDate` and `date`, it is archived for both dates. This happens because in the first iteration (`publishDate`), the post is added to the archive and `valueFound` is set to `true`. In the second iteration (`modifiedDate`), `valueFound` is set to `false` in the `else` branch. That's why in the third iteration (`date`), the post is added to the archive again for that year. Generally, I would prefer a `for` loop or `Array.prototype.reduce()` when early exit is needed, `Array.protoype.forEach()` isn't really suitable for this. To test this, a post should be added to the fixtures which has `publishDate` and `date` in different years, but no `modifiedDate`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a post has
publishDateanddate, it is archived for both dates.This happens because in the first iteration (
publishDate), the post is added to the archive andvalueFoundis set totrue. In the second iteration (modifiedDate),valueFoundis set tofalsein theelsebranch. That's why in the third iteration (date), the post is added to the archive again for that year.Generally, I would prefer a
forloop orArray.prototype.reduce()when early exit is needed,Array.protoype.forEach()isn't really suitable for this.To test this, a post should be added to the fixtures which has
publishDateanddatein different years, but nomodifiedDate.