Skip to content

Ported to Inkscape 1.0 by kind soul roastedneutron#5

Open
hellerbarde wants to merge 2 commits intohellerbarde:masterfrom
roastedneutrons:master
Open

Ported to Inkscape 1.0 by kind soul roastedneutron#5
hellerbarde wants to merge 2 commits intohellerbarde:masterfrom
roastedneutrons:master

Conversation

@hellerbarde
Copy link
Owner

Thank you a lot! I'll try it out soon and then merge it. If that's ok with you!

@roastedneutrons
Copy link

roastedneutrons commented Sep 10, 2020

It would be my pleasure. However, the modifications on my fork also include changes that you might not want merged with your repository. Like the < id > tag in the inx file and the submenu entry it lists under. And also changes to the readme. If you give me commit access, i can push only the relevant changes to your repo.

@roastedneutrons
Copy link

I have an X-carve CNC mill that I need to use it for. And since CNC mills can't cut sharp inner corners, a pattern called a 'dogbone' is used, so that the tabs fit in correctly. (The smallest bit i can use on my mill effectively at fast speeds is 2mm (equivalent to the kerf). So you can probably see how this would be a problem if I'm trying to make a box out of 3mm plywood). The intention of my fork was to be able to do a dogbone version of the tabbed box. I am still in the process of figuring out how to modify the code in your repo to accomplish that. The first step was to get your code running on the newer inkscape version, which is what has been accomplished so far.

@hellerbarde
Copy link
Owner Author

I understand. You might want to look into contributing those changes to boxes.py, that would make sure more people can use it.

@roastedneutrons
Copy link

The boxes.py is very laser centric, and many of the awesome things done there cannot be done with a mill, like the flexible hinge stuff. I'll see where it can fit in though. But let me get to making a successful working dogbone first :)

@roastedneutrons
Copy link

It would be my pleasure. However, the modifications on my fork also include changes that you might not want merged with your repository. Like the < id > tag in the inx file and the submenu entry it lists under. And also changes to the readme. If you give me commit access, i can push only the relevant changes to your repo.

I could make a branch that is safe for you to pull from, if you'd prefer it that way over giving me commit access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants