Skip to content

Conversation

@nerdeveloper
Copy link
Member

@nerdeveloper nerdeveloper commented May 18, 2025

This pull request includes a minor update to the fetchChartsInStorage function in the pkg/chartmuseum/server/multitenant/cache.go file. The change ensures that the repo parameter is joined with an empty string using pathutil.Join when calling the ListObjects method on StorageBackend.

To make it super clear:

Before Fix:
└── bucket
    ├── abc-def-1.1.1.tgz     (ChartMuseum wrongly included these)
    ├── abc-def-1.1.24.tgz    (because they start with "abc")
    └── abc/
        └── xyz-1.1.1.tgz     (should only include this)

After Fix:
└── bucket
    ├── abc-def-1.1.1.tgz     (ChartMuseum correctly ignores these)
    ├── abc-def-1.1.24.tgz    (because they're not in the abc/ folder)
    └── abc/
        └── xyz-1.1.1.tgz     (only includes this, as it should!)

alexberry and others added 14 commits May 18, 2025 21:37
* Ensure uploads using form-data utilise server.PutWithLimit
* Add tests
* Fixes helm#1050

Signed-off-by: alexberry <alex.berry@mpb.com>
Signed-off-by: Obinna Odirionye <odirionye@gmail.com>
Bumps [helm.sh/helm/v3](https://github.com/helm/helm) from 3.17.1 to 3.17.3.
- [Release notes](https://github.com/helm/helm/releases)
- [Commits](helm/helm@v3.17.1...v3.17.3)

---
updated-dependencies:
- dependency-name: helm.sh/helm/v3
  dependency-version: 3.17.3
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Obinna Odirionye <odirionye@gmail.com>
…elm#1070)

Bumps [github.com/golang-jwt/jwt/v4](https://github.com/golang-jwt/jwt) from 4.5.0 to 4.5.2.
- [Release notes](https://github.com/golang-jwt/jwt/releases)
- [Changelog](https://github.com/golang-jwt/jwt/blob/main/VERSION_HISTORY.md)
- [Commits](golang-jwt/jwt@v4.5.0...v4.5.2)

---
updated-dependencies:
- dependency-name: github.com/golang-jwt/jwt/v4
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Obinna Odirionye <odirionye@gmail.com>
….27 (helm#1069)

Bumps [github.com/containerd/containerd](https://github.com/containerd/containerd) from 1.7.24 to 1.7.27.
- [Release notes](https://github.com/containerd/containerd/releases)
- [Changelog](https://github.com/containerd/containerd/blob/main/RELEASES.md)
- [Commits](containerd/containerd@v1.7.24...v1.7.27)

---
updated-dependencies:
- dependency-name: github.com/containerd/containerd
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Obinna Odirionye <odirionye@gmail.com>
Signed-off-by: Casey Buto <cbuto22@gmail.com>
Signed-off-by: Obinna Odirionye <odirionye@gmail.com>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.37.0 to 0.38.0.
- [Commits](golang/net@v0.37.0...v0.38.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-version: 0.38.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Obinna Odirionye <odirionye@gmail.com>
Signed-off-by: Casey Buto <cbuto22@gmail.com>
Signed-off-by: Obinna Odirionye <odirionye@gmail.com>
Signed-off-by: Casey Buto <cbuto22@gmail.com>
Signed-off-by: Obinna Odirionye <odirionye@gmail.com>
Signed-off-by: Obinna Odirionye <odirionye@gmail.com>
Signed-off-by: Obinna Odirionye <odirionye@gmail.com>
Signed-off-by: Obinna Odirionye <odirionye@gmail.com>
…onding test

Signed-off-by: Obinna Odirionye <odirionye@gmail.com>
… version

Signed-off-by: Obinna Odirionye <odirionye@gmail.com>
Signed-off-by: Obinna Odirionye <odirionye@gmail.com>
@nerdeveloper nerdeveloper force-pushed the 794-unable-to-refresh-tenant-index-and-get-new-chart-versions branch from 2ea5294 to e62ccd9 Compare May 18, 2025 17:39
@pull-request-size pull-request-size bot added size/L and removed size/M labels May 18, 2025
@nerdeveloper nerdeveloper deleted the 794-unable-to-refresh-tenant-index-and-get-new-chart-versions branch May 18, 2025 17:43
@nerdeveloper
Copy link
Member Author

i messed up my commits trying to verify commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to refresh tenant index and get new chart versions

3 participants