Make use of timing-safe functions to compare HMAC signatures#329
Open
matical wants to merge 1 commit intohelpscout:masterfrom
Open
Make use of timing-safe functions to compare HMAC signatures#329matical wants to merge 1 commit intohelpscout:masterfrom
matical wants to merge 1 commit intohelpscout:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic string comparisons are not timing-safe for validating HMAC signatures. PHP has a built in function (
hash_equals) that is timing-safe.There are parts of the official Help Scout documentation that should be updated to make use of constant-time string comparisons for validating signatures.
https://developer.helpscout.com/webhooks/
https://developer.helpscout.com/apps/guides/signature-validation/