feat(thread): Implemented associatedEntities functionality#330
Open
wotta wants to merge 1 commit intohelpscout:masterfrom
Open
feat(thread): Implemented associatedEntities functionality#330wotta wants to merge 1 commit intohelpscout:masterfrom
wotta wants to merge 1 commit intohelpscout:masterfrom
Conversation
Contributor
Author
|
Hi @miguelrs, I bet you are busy so this is a gentle ping for opened PR's. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current behavior:
Currently I am unable to fetch the
associatedEntitiesdata from theThreadobject.Changed behavior:
Implemented some logic to hydrate and extract/get the
associatedEntitiesdata from theThreadobject. Main reason for this implementation is because of theconvo.mergedwebhook utilizing this field within the dataset which I need to hook into to resolve some stuff on my end.Changes proposed in this pull request:
associatedEntitiesproperty for theThreadobject.hydratemethod.wasMergedmethod used withinThreadTestto help keeping the test logical.ThreadTest.