Conversation
ClaytonNorthey92
approved these changes
Oct 27, 2025
joshuasing
requested changes
Jan 15, 2026
| BRANCH_NAME="${GITHUB_REF#refs/heads/}" | ||
| echo "Detected branch: $BRANCH_NAME" | ||
|
|
||
| IFS=' ' read -r -a allowed <<< "${{ inputs.allowed-branches }}" |
Contributor
There was a problem hiding this comment.
Is space-separated ideal here? I think comma-separated could be more consistent (e.g. with reviewers):
Suggested change
| IFS=' ' read -r -a allowed <<< "${{ inputs.allowed-branches }}" | |
| IFS=',' read -r -a allowed <<< "${{ inputs.allowed-branches }}" |
| using: "composite" | ||
| steps: | ||
| - name: Check if branch is allowed and create PR | ||
| run: | |
Contributor
There was a problem hiding this comment.
Using ${{ }} syntax within run is dangerous -- as it is replaced before the script is executed, and allows script injection.
Instead, it is best to use environment variables to pass in the variables, e.g.
env:
ALLOWED_BRANCHES: "${{ inputs.allowed-branches }}"
run: |
echo "$ALLOWED_BRANCHES"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a reusable action for Automating PR creation, needed when fluxcd triggers a image automation.
I think this PR can wait until Joshua is back.