Skip to content

Conversation

@ClaytonNorthey92
Copy link
Contributor

Summary

  • added a new profile in the testnet docker compose called "hemitrap". this profile sets up a forked network of our testnet to test deploying smart contract updatest, then running localnet tests against them
  • there is explicitly no README added; this is simply a new docker compose profile to be used by the greater ecosystem

Changes
see summary.

@ClaytonNorthey92 ClaytonNorthey92 marked this pull request as ready for review October 13, 2025 15:58
@ClaytonNorthey92 ClaytonNorthey92 requested a review from a team as a code owner October 13, 2025 15:58
@joshuasing
Copy link
Contributor

Question - Do we want to do this as a part of the existing docker-compose file(s)? Would this potentially be better to implement as separate compose files to avoid accidental use? 🤔

@ClaytonNorthey92
Copy link
Contributor Author

@joshuasing it shares volumes with the original compose file, namely the op-geth-l2 volumes (geth and tbc). so it would be easiest to have it in the same file.

the steps are:

  • sync a node
  • stop the synced node
  • run the hemitrap profile

it will pick up where that synced node left off and work on its own fork

Copy link
Contributor

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add this to the documentation.

@ClaytonNorthey92
Copy link
Contributor Author

You need to add this to the documentation.

@jcvernaleo added 👍 let me know if you want me to add anything else

- hemitrap
environment:
ANVIL_IP_ADDR: '0.0.0.0'
image: ghcr.io/foundry-rs/foundry:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pin this to a specific tag and sha256 digest:

Suggested change
image: ghcr.io/foundry-rs/foundry:latest
image: ghcr.io/foundry-rs/foundry:v1.4.1@sha256:629bebb49d1ba44a52a9fc14229dd58930e3193b4b206ae43ad00089e9ead95b

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to have been resolved

Copy link
Contributor

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern was covered so I'm hitting approve but looks like @joshuasing's may not be addressed yet and I do think those are important too (the docker image ones in particular.

* added a new profile in the testnet docker compose called "hemitrap".  this profile sets up a forked network of our testnet to test deploying smart contract updatest, then running localnet tests against them
* there is explicitly no README added; this is simply a new docker compose profile to be used by the greater ecosystem
@ClaytonNorthey92 ClaytonNorthey92 force-pushed the clayton/hemitrap branch 2 times, most recently from 0e7d1bf to 5a97fba Compare October 16, 2025 14:36
Co-authored-by: Joshua Sing <joshua@hemi.xyz>
@ClaytonNorthey92 ClaytonNorthey92 merged commit d41c510 into main Oct 16, 2025
2 checks passed
@ClaytonNorthey92 ClaytonNorthey92 deleted the clayton/hemitrap branch October 16, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants