Closed
Conversation
Contributor
christian-heusel
commented
Aug 22, 2023
christian-heusel
commented
- chore: update pdfcpu to version 0.5.0
- chore: bump go in the dockerfile to version 1.21
- fix: skip images that cannot be decoded instead of crashing
|
Are there any plans to merge this? |
Owner
|
If I remember correctly I have not merged, because the issues of #10 (comment) are still not adressed. There seems to be a problem with iOS(default annotation app) on latex generated files. I did not find the exact reproducability. This lead to some improvement in the testing situation that I have yet to push. If @Splines and @christian-heusel can confirm that this update is working on some pdfs, I am glad to merge this already (adding CI can be done later). |
|
Sorry, I don't possess any device made by Apple, so I cannot test this. |
Owner
|
I am talking about general pdfs. It suffices for me to only check some, not this "special" case. |
Open
Contributor
Author
|
Closed in favor of #12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.