Skip to content

fix: open OSC 8 file links - #1938

Closed
EAnderson-Shopify wants to merge 1 commit into
herdrdev:masterfrom
EAnderson-Shopify:fix/osc8-link-schemes
Closed

fix: open OSC 8 file links#1938
EAnderson-Shopify wants to merge 1 commit into
herdrdev:masterfrom
EAnderson-Shopify:fix/osc8-link-schemes

Conversation

@EAnderson-Shopify

@EAnderson-Shopify EAnderson-Shopify commented Jul 27, 2026

Copy link
Copy Markdown

What

  • Let explicit OSC 8 file:// metadata reach the existing modified-click opener.
  • Preserve the existing http:// / https:// behavior.
  • Keep unsafe schemes and plain-text file:// strings inert.

Reproduction

In Herdr 0.7.4 or 0.7.5, emit an OSC 8 file link and Ctrl-click its label:

printf '\033]8;;file:///tmp/example.txt\033\\open file\033]8;;\033\\\n'

Before this change, url_at_pane_cell drops the target through the HTTP-only safe_web_url filter. The added regression covers HTTP metadata precedence, file:// acceptance, and unsafe-scheme rejection.

Verification

  • cargo fmt --check passes.
  • Repository CI passes on macOS, Ubuntu, and Windows, including the Windows ConPTY package check.
  • Local Rust execution was blocked before tests by the vendored libghostty-vt Zig build crashing in the Nix dev shell; repository CI completed the full check matrix successfully.

@kangal-bot kangal-bot added coderabbit-review greptile-review Trigger Greptile review for contributor-approved pull requests labels Jul 27, 2026
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3932688c-c250-4fac-9c10-202ec0e4c81c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coderabbit-review greptile-review Trigger Greptile review for contributor-approved pull requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants