feat(session): allow per-agent extra args on native resume - #2105
feat(session): allow per-agent extra args on native resume#2105Chibionos wants to merge 1 commit into
Conversation
Native restore hardcodes argv like `claude --resume <id>` and `codex resume <id>`, so YOLO / bypass-permissions flags are lost on server restart. Add `[session.resume_extra_args]` so users can inject global CLI flags after the executable (e.g. claude + --dangerously-skip-permissions, codex + --yolo).
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
Hi @Chibionos, thanks for your interest in contributing! Herdr automatically admits focused bug fixes from contributors who are not maintainers when the title uses Contributors who are not maintainers may submit only focused bug fixes. If this pull request fixes a bug, rename it to use a conventional Feature requests, behavior changes, and other proposals belong in GitHub Discussions and require maintainer approval before a pull request. If this gate classified the pull request incorrectly, reply and tag a maintainer listed in Patch size: 8 changed files, 278 changed lines. See https://github.com/herdrdev/herdr/blob/master/CONTRIBUTING.md for the contribution policy. |
|
Thanks @kangal-bot — expected close under the non-maintainer feature gate. This is a feature/behavior change, not a bug fix, so it stays as a Discussion first per CONTRIBUTING:
@ogulcancelik if you approve the discussion direction, please reopen this PR (or open a maintainer PR from the branch) with a scope override. I will not reopen it myself. |
Summary
Adds
[session.resume_extra_args]so native agent session restore can inject per-agent CLI flags after the executable (e.g. Claude bypass-permissions, Codex--yolo).Discussion (required for feature direction): #2104
Per CONTRIBUTING this is a behavior/feature change; maintainers may need to grant a scope override for non-
fix:PRs. Draft until aligned.Example
Becomes on restore:
claude --dangerously-skip-permissions --resume <id>codex --yolo resume <id>Changes
SessionConfig.resume_extra_argswith validation (canonical agent ids, arg length/count/control-char checks)plan_with_extra_argsinserts args after argv[0]Out of scope
herdr agent start(separate from restore)Test plan
cargo test extra_args/restore_plan/resume_agentsrelated unit testspython3 scripts/config_reference_check.pycargo fmt --check