Skip to content

Alice Vision fixes and newer version#1

Open
zeuner wants to merge 10000 commits into
hesiod:alice-visionfrom
zeuner:alice-vision
Open

Alice Vision fixes and newer version#1
zeuner wants to merge 10000 commits into
hesiod:alice-visionfrom
zeuner:alice-vision

Conversation

@zeuner
Copy link
Copy Markdown

@zeuner zeuner commented Sep 10, 2023

Description of changes

I saw your pull request NixOS#224262 and fixed the build, and added the newer version. I could successfully run a 3D reconstruction through the 3.0.0 build. The 3.1.0 one currently fails here (in contrast to my independently written build NixOS@8411621), which is still to be investigated.

I thought I contribute to your branch instead of adding a separate PR.

This should also help with NixOS#216403

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.