handle transitive deps of additional_link_libraries
#77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This PR is based off of #75 and the contents of this PR is contained in the last commit. If you want to merge this first, we can rebase off |
Owner
|
I think there is a conflict with the bezel lock file, but otherwise we can merge this too |
When defining an `additional_link_library` that uses `deps`, e.g.
```starlark
cc_library(
name = "start",
srcs = ["start.c"],
...
deps = [":registers"],
)
```
where the `start` library depends on a separate `registers` library,
libraries in `deps` are not compiled. Similar to
`additional_linker_inputs`, these files must be explicitly forwarded in
the DefaultInfo returned by the transition implementation function.
oliverlee
force-pushed
the
transitive-additional-link-libraries
branch
from
f298f45 to
edfe4f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When defining an
additional_link_librarythat usesdeps, e.g.where the
startlibrary depends on a separateregisterslibrary,libraries in
depsare not compiled.Similar to
additional_linker_inputs, these files must be explicitly forwarded inthe
DefaultInforeturned by the transition implementation function.